ZOOKEEPER-4915: Default znode.container.maxNeverUsedIntervalMs to 5 minutes #2248
+19
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inutes This will delete container nodes that never had any children after approximately 5 minutes. > Given this property, you should be prepared to get `KeeperException.NoNodeException` > when creating children inside of this container node Container nodes are supposed to be deleted after all children deleted, so from client's perspective this change has no harm. And also, it leaves no unused nodes in data tree.
kezhuw
force-pushed
the
ZOOKEEPER-4915-znode.container.maxNeverUsedIntervalMs-default-value
branch
from
bd7ca89 to
3121b0d
Compare
zeekling
suggested changes
Jul 20, 2025
| zkDb, requestProcessor, | ||
| Integer.getInteger("znode.container.checkIntervalMs", (int) TimeUnit.MINUTES.toMillis(1)), | ||
| Integer.getInteger("znode.container.maxPerMinute", 10000), | ||
| Long.getLong("znode.container.maxNeverUsedIntervalMs", TimeUnit.MINUTES.toMillis(5)) |
There was a problem hiding this comment.
The default 5-minute cleanup is a breaken change and is not recommended i think.
There was a problem hiding this comment.
How does it break things ? Container nodes with no children are supposed to be deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will delete container nodes that never had any children after approximately 5 minutes.
Container nodes are supposed to be deleted after all children deleted, so from client's perspective this change has no harm. And also, it leaves no unused nodes in data tree.